fix(ci): download artifact before pnpm setup in publish job#40
Merged
Conversation
The publish job has no checkout step, so package.json (with the packageManager field) only exists after the artifact download. Running pnpm/action-setup first leaves it with no pnpm version to read.
There was a problem hiding this comment.
Pull request overview
This PR updates GitHub Actions workflows to make the release.yml publish job reliably set up pnpm by ensuring the artifact containing package.json is available before pnpm/action-setup runs, and fixes a YAML indentation issue.
Changes:
- Reorders the
publishjob steps inrelease.ymlso the package artifact download happens before pnpm setup. - Fixes a mis-indented
Setup Node.jsstep in therelease.ymlpublishjob. - Updates workflow Node versions from 22 to 24 across CI/release/demo workflows.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/test.yml | Updates the workflow Node version to 24 (and fixes indentation of the node-version line). |
| .github/workflows/release.yml | Reorders publish steps (download artifact before pnpm setup), fixes mis-indentation, and bumps Node version to 24. |
| .github/workflows/demo.yml | Updates the workflow Node version to 24 (and fixes indentation of the node-version line). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+83
to
+87
| - name: ⬇️ Download package artifact | ||
| uses: actions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093 # v4 | ||
| with: | ||
| name: package | ||
|
|
Comment on lines
31
to
33
| with: | ||
| node-version: 22 | ||
| node-version: 24 | ||
| cache: pnpm |
Comment on lines
23
to
26
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 | ||
| with: | ||
| node-version: 22 | ||
| node-version: 24 | ||
| cache: pnpm |
Comment on lines
22
to
26
| - name: ⎔ Setup Node.js | ||
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 | ||
| with: | ||
| node-version: 22 | ||
| node-version: 24 | ||
| cache: pnpm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
publishjob has nocheckoutstep, sopackage.json(withpackageManager) only exists after the artifact download. Runningpnpm/action-setupfirst leaves it with no pnpm version to read — the same failure mode that broke codemirror-sql's release once it moved to action-setup v6 (v4 still has a fallback, so this is latent here).Fix: reorder so the artifact download runs before pnpm setup.
Also fixes a pre-existing mis-indented
Setup Node.jsstep.