Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add support for llama, refactor yaml service interface #115

Merged
merged 4 commits into from
Jul 21, 2024

Conversation

mariocandela
Copy link
Owner

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally before submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Closes #114

@mariocandela mariocandela added the enhancement New feature or request label Jul 21, 2024
@mariocandela mariocandela self-assigned this Jul 21, 2024
@mariocandela mariocandela linked an issue Jul 21, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 95.58824% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.30%. Comparing base (0af1a05) to head (3ba605f).

Files Patch % Lines
plugins/llm-integration.go 95.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   92.17%   91.30%   -0.87%     
==========================================
  Files           5        5              
  Lines         230      276      +46     
==========================================
+ Hits          212      252      +40     
- Misses         12       16       +4     
- Partials        6        8       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariocandela mariocandela marked this pull request as ready for review July 21, 2024 18:10
@mariocandela mariocandela merged commit 2088163 into main Jul 21, 2024
4 of 5 checks passed
@mariocandela mariocandela deleted the 114-support-for-llama3-ollama-supported-llms branch July 21, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Llama3 / Ollama supported LLMs
1 participant