ci: restore npm install and drop broken npm upgrade step - #24
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR adjusts the GitHub Actions release workflow to unblock publishing by removing an npm self-upgrade step and changing how dependencies are installed during the release job.
Changes:
- Removed the “Update npm for OIDC support” step (
npm install -g npm@latest). - Switched dependency installation in the release workflow from
npm citonpm install.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
| run: npm install |
There was a problem hiding this comment.
The release workflow switched from npm ci to npm install. Since this repo commits a package-lock.json (and CI uses npm ci elsewhere), using npm install here can make the release build less reproducible and may modify package-lock.json during the run, potentially leaving a dirty working tree that interferes with changesets/action when it opens a release PR. Prefer npm ci in the release job as well (or, if npm ci was failing, fix the lockfile mismatch rather than falling back to npm install).
| run: npm install | |
| run: npm ci |
Two changes to unblock the v2.0.0 release: