Skip to content

ci: restore npm install and drop broken npm upgrade step - #24

Merged
marioprieta merged 2 commits into
mainfrom
ci/fix-release-node22
Apr 22, 2026
Merged

ci: restore npm install and drop broken npm upgrade step#24
marioprieta merged 2 commits into
mainfrom
ci/fix-release-node22

Conversation

@marioprieta

Copy link
Copy Markdown
Owner

Two changes to unblock the v2.0.0 release:

@vercel

vercel Bot commented Apr 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-native-theme-transition Ready Ready Preview, Comment Apr 22, 2026 11:04am

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the GitHub Actions release workflow to unblock publishing by removing an npm self-upgrade step and changing how dependencies are installed during the release job.

Changes:

  • Removed the “Update npm for OIDC support” step (npm install -g npm@latest).
  • Switched dependency installation in the release workflow from npm ci to npm install.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/release.yml Outdated

- name: Install dependencies
run: npm ci
run: npm install

Copilot AI Apr 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release workflow switched from npm ci to npm install. Since this repo commits a package-lock.json (and CI uses npm ci elsewhere), using npm install here can make the release build less reproducible and may modify package-lock.json during the run, potentially leaving a dirty working tree that interferes with changesets/action when it opens a release PR. Prefer npm ci in the release job as well (or, if npm ci was failing, fix the lockfile mismatch rather than falling back to npm install).

Suggested change
run: npm install
run: npm ci

Copilot uses AI. Check for mistakes.
@marioprieta
marioprieta merged commit d28b33a into main Apr 22, 2026
9 of 10 checks passed
@marioprieta
marioprieta deleted the ci/fix-release-node22 branch April 22, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants