-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix plugin to run on current versions of Obsidian. #3
base: main
Are you sure you want to change the base?
Conversation
…ackages and build to the latest versions.
# Conflicts: # src/ConfluencePerPageForm.tsx
What needs to be done to get this merged/fixed? Just got obsidian to work with confluence and found the plugin is busted. |
It appears the project is abandoned, last commit over a year ago. |
Considering this project seems to be abandoned, could you @jcfergus post basic instructions on how to install this manually? |
You can install with BRAT with : https://github.com/lucasiscovici/obsidian-integration/ |
Thanks for this! Just for clarity for any future folks unfamiliar with BRAT as I was, you want to add it with a frozen version not just as a beta plugin: |
I had to install-then-uninstall-then-install-again in order to get it to work, but it works now. Thanks!! |
This updates the dependencies and code to use the latest Obisdian sample plugin as a base, to solve these errors preventing the plugin from being enabled on recent versions of Obsidian.
i.e. markdown-confluence/markdown-confluence#651
I have tested it successfully on Obsidian 1.7.4, I don't know about other versions. There are no actual code changes in src/ConfluencePerPageForm.tsx, beyond adding some explicit
any
types in a few spots to get eslint/tsc to not complain about them - my IDE "fixed" a few indents. I can revert those indentation changes if needed.