MLE-23004 - Addresses compiler warnings in the Java Client

[BillFarber]

Addresses compiler warnings identified in the MarkLogic Java Client.

• Replaces new Long(long).longValue() with Long.parseLong(long) or Long.valueOf(long).longValue() for efficiency.
• Uses StandardCharsets.UTF_8 instead of "UTF-8" String literals.
• Removes unused variables and unnecessary checks.

[Copilot]

Pull Request Overview

This PR addresses compiler warnings in the MarkLogic Java Client by modernizing deprecated API usage and improving code quality. The changes focus on replacing deprecated methods with their modern equivalents and removing unnecessary code constructs.

• Replaces deprecated capitalize() method with replaceFirstChar { it.uppercase() } in Kotlin code
• Updates primitive wrapper instantiation patterns (new Integer(), new Long()) with modern alternatives
• Replaces string literals for character encodings with StandardCharsets.UTF_8
• Modernizes Gradle task registration and improves iterator usage patterns

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
Generator.kt	Updates deprecated capitalize() calls and toUpperCase() to modern Kotlin string methods
ToolsPlugin.kt	Replaces deprecated tasks.create() with tasks.register() for lazy task creation
SSLTest.java	Removes unnecessary new Integer() wrapper instantiation and improves code formatting
HandleAsTest.java	Replaces UTF-8 string literals with StandardCharsets.UTF_8 and improves code formatting
BasicPage.java	Updates new Long() constructor usage to Long.valueOf() and improves formatting
TypedRow.java	Replaces inefficient new Long().longValue() pattern with Long.parseLong()

[Copilot]

Using Long.parseLong(rowNum) assumes rowNum is a String, but this could cause a NumberFormatException if rowNum contains invalid numeric data. The original code using new Long(rowNum).longValue() suggests rowNum might be a long primitive. If rowNum is already a long, this should be just 'return rowNum;' or if it's a String that represents a long value, consider using Long.valueOf(rowNum) for consistency with the caching behavior used elsewhere in the PR.

Suggested change

	return Long.parseLong(rowNum);
	try {
	return Long.valueOf(rowNum).longValue();
	} catch (NumberFormatException e) {
	throw new IllegalArgumentException("Invalid rowNum value: " + rowNum, e);
	}

[rjrudin]

Can you resubmit this without the formatting changes? Unfortunately most Java Client source files aren't formatted based on .editorconfig. That's a separate effort, have this PR contain the compilation warning fixes.

[rjrudin]

All looks good, except still have whitespace changes in BasicPage and SSLTest. I just want to avoid those so that the "git blame" shows the real last author of each line, which is useful for quickly debugging some of these older files.

[rjrudin]

HOT