MLE-24523 Debugging reverse proxy tests #1840
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
rjrudin
force-pushed
the
feature/24523-reverse-proxy-tests
branch
7 times, most recently
from
a129d7a to
b483303
Compare
rjrudin
force-pushed
the
feature/24523-reverse-proxy-tests
branch
from
b483303 to
c3933b8
Compare
There was a problem hiding this comment.
Pull Request Overview
Updates configuration and test infrastructure to debug and enable reverse proxy server tests that were previously disabled due to issue MLE-24523.
- Re-enables reverse proxy test stages in the Jenkins pipeline
- Updates port configurations and Docker container mappings to support reverse proxy testing
- Modifies test assertions to be more flexible for connection error messages
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test-app/README.md | Adds documentation for running tests with reverse proxy server |
| marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/functionaltest/BulkIOCallersFnTest.java | Changes REST test port from 8093 to 8015 |
| marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/fastfunctest/TestDatabaseClientConnection.java | Makes connection error assertion more flexible |
| docker-compose.yaml | Consolidates port mappings to use range 8010-8015 |
| Jenkinsfile | Re-enables reverse proxy tests and updates Docker images |
| .copyrightconfig | Adds docker-compose.yaml to excluded files list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| To run one or more tests with the reverse proxy server being started, the tests being run, and then the server being | ||
| stopped, do the following (you can see examples of this in the project `Jenkinsfile` as well): | ||
|
|
||
| ./gradlew -PtestUseReverseProxyServer=true runReverseProxyServer marklogic-client-api:test --tests ReadDocumentPageTest |
There was a problem hiding this comment.
The indentation uses tabs instead of spaces, which is inconsistent with the rest of the file that uses spaces. Consider using consistent spacing.
Suggested change
| ./gradlew -PtestUseReverseProxyServer=true runReverseProxyServer marklogic-client-api:test --tests ReadDocumentPageTest | |
| ./gradlew -PtestUseReverseProxyServer=true runReverseProxyServer marklogic-client-api:test --tests ReadDocumentPageTest |
Copilot uses AI. Check for mistakes.
|
Closing this, the other PR is better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.