MLE-21148 Add Retry for Group Config #321
Open
+24
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pengzhouml
requested review from
vitalykorolev,
rwinieski,
barkhachoithani and
sumanthravipati
|
Pipeline is failing. Please review. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a retry mechanism for group configuration to increase the robustness of the configuration process.
- Added a new retry() helper function to encapsulate retry logic.
- Replaced direct configure_group calls with retry wrappers to attempt group configuration up to 5 times.
- Added explicit return codes on failure paths in group configuration.
| @@ -176,6 +174,22 @@ data: | |||
| echo $message >> /tmp/script.log | |||
| } | |||
|
|
|||
| retry() { | |||
There was a problem hiding this comment.
[nitpick] Consider adding a comment above the retry function to explain its parameters and behavior, which would help maintainers quickly understand its purpose.
Copilot uses AI. Check for mistakes.
| return $exit_code | ||
| fi | ||
| echo "Attempt $count failed. Retrying..." | ||
| sleep 5 |
There was a problem hiding this comment.
[nitpick] Consider making the retry delay configurable instead of hard-coding a 5-second sleep to allow easier adjustments in different environments.
Suggested change
| sleep 5 | |
| sleep ${RETRY_DELAY:-5} |
Copilot uses AI. Check for mistakes.
pengzhouml
force-pushed
the
bugfix/MLE-21148-group-retry
branch
from
dfde5bf to
6e2d9a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.