Skip to content

Minor fixes to compose.healthcheck.yaml and Makefile #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release/next
Choose a base branch
from

Conversation

mrifqyabdallah
Copy link

1. Increase the retries number on the compose.healthcheck.yaml file, from 3 to 30

Fixes #1346. See my comment inside.

2. Fixed typo and syntax error on the Makefile

After cloning the repo and running make on my CLI, I get the following error:

Screenshot 2025-06-19 135157

At line 42 of the Makefile file, turns out there's a missing parentheses.

I also escape all the backticks and change all comma signs with the $(comma) variable in order to remove the unexpected EOF warning.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 19, 2025
Copy link

what-the-diff bot commented Jun 19, 2025

PR Summary

  • Enhancement of formatting in Help command texts
    The layout of command arguments in the Help section has been refined for easy comprehension. This update includes appropriate escape methods for backticks and the use of commas for a clear understanding of values.

  • Modification of description for several commands
    The content description for a series of commands within the Help text has been standardized, promoting a more uniform and readable user experience. These commands include: phpstan analyse, blackfire, configure-linux, debug-cli, deploy, magento-version, phpcs-json-report, spx, and xdebug.

  • Increased Retries for Health Checks
    The number of retries for health checks has been increased from 3 to 30. This change will allow for more attempts at system checks, thereby increasing the reliability of our service.

@dosubot dosubot bot added the bug label Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dependency failed to start: container 248-opensearch-1 is unhealthy
1 participant