Skip to content

Fix mutable default argument values #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

g-nie
Copy link

@g-nie g-nie commented Apr 8, 2025

Hey there, I noticed some function arguments using mutable types (sets, dicts) as default values.
While this doesn't appear to cause issues right now, it could lead to unexpected behavior if any future code modifies these default objects.
I thought to change the defaults to None and initialize them in the __init__s if needed. What do you think?

Copy link

@blag blag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely needed.

There are alternative ways to do this, but the way you chose works perfectly fine.

Comment on lines +29 to +34
if attributes is None:
attributes = {}
if clean_content_tags is None:
clean_content_tags = set()
if tags is None:
tags = set()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can also do this:

Suggested change
if attributes is None:
attributes = {}
if clean_content_tags is None:
clean_content_tags = set()
if tags is None:
tags = set()
attributes = attributes or {}
clean_content_tags = clean_content_tags or set()
tags = tags or set()

Comment on lines +29 to +34
if attributes is None:
attributes = {}
if clean_content_tags is None:
clean_content_tags = set()
if tags is None:
tags = set()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same suggestion as above, just adding it to make your life easier if you like this better:

Suggested change
if attributes is None:
attributes = {}
if clean_content_tags is None:
clean_content_tags = set()
if tags is None:
tags = set()
attributes = attributes or {}
clean_content_tags = clean_content_tags or set()
tags = tags or set()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants