-
Notifications
You must be signed in to change notification settings - Fork 7
Fix mutable default argument values #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely needed.
There are alternative ways to do this, but the way you chose works perfectly fine.
if attributes is None: | ||
attributes = {} | ||
if clean_content_tags is None: | ||
clean_content_tags = set() | ||
if tags is None: | ||
tags = set() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can also do this:
if attributes is None: | |
attributes = {} | |
if clean_content_tags is None: | |
clean_content_tags = set() | |
if tags is None: | |
tags = set() | |
attributes = attributes or {} | |
clean_content_tags = clean_content_tags or set() | |
tags = tags or set() |
if attributes is None: | ||
attributes = {} | ||
if clean_content_tags is None: | ||
clean_content_tags = set() | ||
if tags is None: | ||
tags = set() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same suggestion as above, just adding it to make your life easier if you like this better:
if attributes is None: | |
attributes = {} | |
if clean_content_tags is None: | |
clean_content_tags = set() | |
if tags is None: | |
tags = set() | |
attributes = attributes or {} | |
clean_content_tags = clean_content_tags or set() | |
tags = tags or set() |
Hey there, I noticed some function arguments using mutable types (sets, dicts) as default values.
While this doesn't appear to cause issues right now, it could lead to unexpected behavior if any future code modifies these default objects.
I thought to change the defaults to
None
and initialize them in the__init__
s if needed. What do you think?