Add missing tests for preview

marp-team · Sep 27, 2024 · 36c95af · 36c95af
1 parent 81bf08e
commit 36c95af
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 6 deletions.
diff --git a/src/preview.ts b/src/preview.ts
@@ -169,9 +169,11 @@ export class Preview extends (EventEmitter as new () => TypedEmitter<Preview.Eve
 
             if (url.searchParams.get('__marp_cli_id') === id) {
               debugPreview('Found a target window with id: %s', id)
-
               pptr.off('targetcreated', idMatcher)
-              ;(async () => res((await target.page())!))()
+
+              void (async () => {
+                res((await target.page()) ?? (await target.asPage()))
+              })()
             }
           }
 
@@ -187,8 +189,21 @@ export class Preview extends (EventEmitter as new () => TypedEmitter<Preview.Eve
               `window.open('about:blank?__marp_cli_id=${id}', '', 'width=${this.options.width},height=${this.options.height}')`
             )
           })()
-        }).then((page) => {
-          debugPreview('Created new window!: %s', page.url())
+        }).then(async (page) => {
+          const sizeCorrection = await page.evaluate(
+            ([w, h]) => {
+              const nw = w - window.innerWidth + w
+              const nh = h - window.innerHeight + h
+
+              window.resizeTo(nw, nh)
+              return [nw, nh]
+            },
+            [this.options.width, this.options.height]
+          )
+
+          debugPreview('Apply window size correction: %o', sizeCorrection)
+          debugPreview('Created new window: %s', page.url())
+
           return page
         })
       )

diff --git a/test/preview.ts b/test/preview.ts
@@ -78,8 +78,8 @@ describe('Preview', () => {
           width: window.innerWidth,
         }))
 
-        expect(height).toBeLessThanOrEqual(600)
-        expect(width).toBeLessThanOrEqual(400)
+        expect(height).toBe(600)
+        expect(width).toBe(400)
       })
     })
 
@@ -134,6 +134,16 @@ describe('Preview', () => {
           ))
       })
     })
+
+    describe('when opening data URI', () => {
+      it('opens data URI converted Blob URL to avoid URL length limit', async () => {
+        const instance = preview()
+        const win = await instance.open('data:text/html,<html></html>')
+
+        expect(await instance.puppeteer?.pages()).toHaveLength(1)
+        expect(win.page.url()).toStrictEqual(expect.stringMatching(/^blob:/))
+      })
+    })
   })
 })