Disable GPU acceleration in CI tests to mitigate flakiness

marp-team · Jan 21, 2025 · 4690bb4 · 4690bb4
1 parent c74519b
commit 4690bb4
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -99,6 +99,7 @@ commands:
           name: Jest
           command: npm run test:coverage -- --ci --reporters=default --reporters=jest-junit <<#parameters.runInBand>>-i<</parameters.runInBand>><<^parameters.runInBand>>--maxWorkers=2<</parameters.runInBand>>
           environment:
+            CHROME_DISABLE_GPU: 1 # Disable GPU acceleration to mitigate flaky tests
             JEST_JUNIT_CLASSNAME: '{filepath}'
             JEST_JUNIT_OUTPUT_DIR: tmp/test-results
             MARP_TEST_CI: 1

diff --git a/.github/workflows/test-win.yml b/.github/workflows/test-win.yml
@@ -48,6 +48,7 @@ jobs:
       # https://stackoverflow.com/a/59365905
       - name: Jest
         env:
+          CHROME_DISABLE_GPU: 1 # Disable GPU acceleration to mitigate flaky tests
           JEST_JUNIT_CLASSNAME: '{filepath}'
           JEST_JUNIT_OUTPUT_DIR: tmp/test-results
           MARP_TEST_CI: 1

diff --git a/test/browser/browsers/chrome.ts b/test/browser/browsers/chrome.ts
@@ -132,6 +132,17 @@ describe('ChromeBrowser', () => {
       })
 
       describe('Disabling GPU', () => {
+        it('does not add --disable-gpu argument if CHROME_DISABLE_GPU environment variable is not defined', async () => {
+          delete process.env.CHROME_DISABLE_GPU
+          await new ChromeBrowser({ path: '/path/to/chrome' }).launch()
+
+          expect(puppeteer.launch).toHaveBeenCalledWith(
+            expect.objectContaining({
+              args: expect.not.arrayContaining(['--disable-gpu']),
+            })
+          )
+        })
+
         it('adds --disable-gpu argument if CHROME_DISABLE_GPU environment variable is defined', async () => {
           process.env.CHROME_DISABLE_GPU = '1'
           await new ChromeBrowser({ path: '/path/to/chrome' }).launch()