Improve flaky tests about JPEG conversion

Update `imageScale` option for testing to reduce memory usage.
marp-team · Jan 21, 2025 · 5a37385 · 5a37385
1 parent c21153a
commit 5a37385
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 13 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -97,7 +97,7 @@ commands:
     steps:
       - run:
           name: Jest
-          command: npm run test:coverage -- --ci --reporters=default --reporters=jest-junit <<# parameters.runInBand >>-i<</ parameters.runInBand >>
+          command: npm run test:coverage -- --ci --maxWorkers=2 --reporters=default --reporters=jest-junit <<# parameters.runInBand >>-i<</ parameters.runInBand >>
           environment:
             JEST_JUNIT_CLASSNAME: '{filepath}'
             JEST_JUNIT_OUTPUT_DIR: tmp/test-results

diff --git a/.github/workflows/test-win.yml b/.github/workflows/test-win.yml
@@ -53,7 +53,7 @@ jobs:
           MARP_TEST_CI: 1
         run: >-
           npm run test:coverage -- --ci --max-workers ${{ steps.cpu-cores.outputs.count }} --reporters=default --reporters=jest-junit ||
-          npm run test:coverage -- --ci --bail -i --reporters=default --reporters=jest-junit --no-cache ||
+          npm run test:coverage -- --ci --bail -i --reporters=default --reporters=jest-junit ||
           npm run test:coverage -- --ci --bail -i --reporters=default --reporters=jest-junit --no-cache ||
           npm run test:coverage -- --ci --bail -i --reporters=default --reporters=jest-junit --no-cache
 

diff --git a/test/converter.ts b/test/converter.ts
@@ -1287,16 +1287,16 @@ describe('Converter', () => {
             await instance({
               output: 'b.jpg',
               type: ConvertType.jpeg,
-              imageScale: 0.5,
+              imageScale: 0.25,
             }).convertFile(new File(onePath))
 
             expect(writeFileSpy.mock.calls[0][1]).toBeInstanceOf(Buffer)
 
             const jpeg = writeFileSpy.mock.calls[0][1] as Buffer
             const { width, height } = imageSize(jpeg)
 
-            expect(width).toBe(640)
-            expect(height).toBe(360)
+            expect(width).toBe(320)
+            expect(height).toBe(180)
           },
           timeoutLarge
         )
@@ -1309,14 +1309,14 @@ describe('Converter', () => {
             await using browserManager = new BrowserManager({
               finders: ['chrome', 'edge'],
               protocol: 'webDriverBiDi',
-              timeout,
+              timeout: timeoutLarge,
             })
 
             await instance({
               browserManager,
               output: 'b.jpg',
               type: ConvertType.jpeg,
-              imageScale: 0.5,
+              imageScale: 0.25,
             }).convertFile(new File(onePath))
 
             const [lastCall] = writeFileSpy.mock.calls.slice(-1)
@@ -1325,8 +1325,8 @@ describe('Converter', () => {
             const jpeg = lastCall[1] as Buffer
             const { width, height } = imageSize(jpeg)
 
-            expect(width).toBe(640)
-            expect(height).toBe(360)
+            expect(width).toBe(320)
+            expect(height).toBe(180)
 
             // Check JPEG quality is working
             writeFileSpy.mockClear()
@@ -1353,14 +1353,14 @@ describe('Converter', () => {
           async () => {
             await using browserManager = new BrowserManager({
               finders: ['firefox'],
-              timeout,
+              timeout: timeoutLarge,
             })
 
             await instance({
               browserManager,
               output: 'b.jpg',
               type: ConvertType.jpeg,
-              imageScale: 0.5,
+              imageScale: 0.25,
             }).convertFile(new File(onePath))
 
             const [lastCall] = writeFileSpy.mock.calls.slice(-1)
@@ -1369,8 +1369,8 @@ describe('Converter', () => {
             const jpeg = lastCall[1] as Buffer
             const { width, height } = imageSize(jpeg)
 
-            expect(width).toBe(640)
-            expect(height).toBe(360)
+            expect(width).toBe(320)
+            expect(height).toBe(180)
 
             // Check JPEG quality is working
             writeFileSpy.mockClear()