Skip to content

Commit

Permalink
Add test case about uncovered debug message in Browser class
Browse files Browse the repository at this point in the history
  • Loading branch information
yhatt committed Jan 19, 2025
1 parent 0bf6318 commit cb85add
Showing 1 changed file with 26 additions and 0 deletions.
26 changes: 26 additions & 0 deletions test/browser/manager.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,16 @@
import debug from 'debug'
import { Browser } from '../../src/browser/browser'
import { ChromeBrowser } from '../../src/browser/browsers/chrome'
import { ChromeCdpBrowser } from '../../src/browser/browsers/chrome-cdp'
import { FirefoxBrowser } from '../../src/browser/browsers/firefox'
import * as browserFinder from '../../src/browser/finder'
import { BrowserManager } from '../../src/browser/manager'

jest.mock('debug', () => {
const debugMock = jest.fn()
return () => debugMock
})

afterEach(() => {
jest.resetAllMocks()
jest.restoreAllMocks()
Expand All @@ -25,6 +32,25 @@ describe('Browser manager', () => {
expect(manager._preferredProtocol).toBe('webDriverBiDi')
expect(manager.timeout).toBe(12345)
})

it('cannot update the browser protocol after the browser is created', async () => {
const manager = new BrowserManager({ protocol: 'webDriverBiDi' })
const debugMock = debug('test')

const browser = await manager.browserForConversion()
expect(browser).toBeInstanceOf(Browser)
expect(browser.protocol).toBe('webDriverBiDi')

manager.configure({ protocol: 'cdp' })
expect(debugMock).toHaveBeenCalledWith(
expect.stringContaining(
'Changing protocol after created browser for conversion is not supported'
)
)
expect((await manager.browserForConversion()).protocol).toBe(
'webDriverBiDi'
)
})
})

describe('#browserForConversion', () => {
Expand Down

0 comments on commit cb85add

Please sign in to comment.