Skip to content

Commit

Permalink
Does not suggest to install Chromium if the current platform was not …
Browse files Browse the repository at this point in the history
…resolvable Chromium

GoogleChrome/chrome-launcher#278
  • Loading branch information
yhatt committed Sep 10, 2022
1 parent 1c88eb2 commit e1ec5f8
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion src/utils/puppeteer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,14 @@ export const generatePuppeteerLaunchArgs = async () => {
if (!executablePath) {
if (findChromeError) warn(findChromeError.message)

// https://github.com/marp-team/marp-cli/issues/475
// https://github.com/GoogleChrome/chrome-launcher/issues/278
const chromiumResolvable = process.platform === 'linux'

error(
'You have to install Google Chrome, Chromium, or Microsoft Edge to convert slide deck with current options.',
`You have to install Google Chrome${
chromiumResolvable ? ', Chromium,' : ''
} or Microsoft Edge to convert slide deck with current options.`,
CLIErrorCode.NOT_FOUND_CHROMIUM
)
}
Expand Down

0 comments on commit e1ec5f8

Please sign in to comment.