Added setting to make env.openExternal optional (#464)

* added setting to make auto open after export optional * ran prettier * updated with new "exportAutoOpen" config flag * provide feedback about the export process if the file is not automatically opened * ran prettier --------- Co-authored-by: Manuel Kiesel <[email protected]>
marp-team · Jan 23, 2025 · 3f63e27 · 3f63e27
1 parent f821bf6
commit 3f63e27
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -168,6 +168,11 @@
             "JPEG image (first slide only)"
           ]
         },
+        "markdown.marp.exportAutoOpen": {
+          "type": "boolean",
+          "default": true,
+          "description": "Automatically opens the exported file using the default application installed on your operating system."
+        },
         "markdown.marp.mathTypesetting": {
           "type": "string",
           "enum": [

diff --git a/src/commands/export.test.ts b/src/commands/export.test.ts
@@ -187,6 +187,9 @@ describe('#doExport', () => {
 
   it('exports passed document via Marp CLI and opens it', async () => {
     const runMarpCLI = jest.spyOn(marpCli, 'default').mockImplementation()
+    setConfiguration({
+      'markdown.marp.exportAutoOpen': true,
+    })
 
     try {
       const uri = saveURI()

diff --git a/src/commands/export.ts b/src/commands/export.ts
@@ -193,7 +193,9 @@ export const doExport = async (uri: Uri, document: TextDocument) => {
           },
         )
 
-        if (outputToLocalFS) {
+        const shouldOpen = marpConfiguration().get<boolean>('exportAutoOpen')!
+
+        if (outputToLocalFS && shouldOpen) {
           env.openExternal(uri)
         } else {
           const outputUri = Uri.file(outputPath)