Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plantuml support #116

Closed
czhiling opened this issue Jan 4, 2020 · 2 comments
Closed

Plantuml support #116

czhiling opened this issue Jan 4, 2020 · 2 comments

Comments

@czhiling
Copy link

czhiling commented Jan 4, 2020

Thank you very much for developing Marp-vscode.

I would like to ask whether it is possible to render plantuml in Marp -vscode?

Plantuml is powerful yet elegant. It's supported by the extension markdown preview enhanced and some others. It is very useful for us to render many different chart without leaving vscode.

Zhiling

@yhatt
Copy link
Member

yhatt commented Jan 6, 2020

Marp CLI can plug third-party plugin (markdown-it-plantuml) so you can convert Marp Markdown + PlantUML through Marp CLI within VS Code integrated terminal.

const { Marp } = require('@marp-team/marp-core')

module.exports = {
    engine: opts => new Marp(opts).use(require('markdown-it-plantuml'))
}

marp-team/marp-core#112

Marp for VS Code cannot preview the result of Markdown conversion with plugin. We are scaring to make complex rendering logic and huge security hole.

But I know some user want to customize rendering engine of Marp in VS Code (e.g. marp-team/marp-core#136 (comment)) We might work for supporting plugin if security concerns were resolved.

@czhiling
Copy link
Author

czhiling commented Jan 9, 2020

Thank for you very much for the prompt reply. I will try Marp CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants