Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Commands Overhaul #493

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rtfmkiesel
Copy link
Contributor

This is the update to #463, which was made to address #311.

I've implemented @yhatt's feedback (#311 (comment)) into this branch.

There are now 3 export commands:

  • markdown.marp.exportAs which will open a save dialog (as it is now)
  • markdown.marp.exportQuick which will quick export into the document directory with the file type being determined by the setting exportType
  • markdown.marp.exportToSelectedFormat which will quick export into the document directory with the user being asked first for which file type should be used

The old markdown.marp.export is mapped to markdown.marp.exportAs for legacy/compatibility reasons.

I did not touch the existing functions doExport and saveDialog.startExport only exists to have a target for unit tests when calling exportQuick or exportToSelectedFormat.

I also had to run npm audit fix to update two dependencies.

Please note, I've not worked with jest before so the unit test may need improvement.

@rtfmkiesel rtfmkiesel changed the title Export cmd overhaul Export Commands Overhaul Feb 9, 2025
@rtfmkiesel
Copy link
Contributor Author

I find the naming of the commands to confusing. My proposal would be the following:

  • Export Slide Deck to ... (file dialog)
  • Export Slide Deck as ... (Quick) (format selection + quick export)
  • Export Slide Deck (Quick) (quick export based on settings)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant