Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the update to #463, which was made to address #311.
I've implemented @yhatt's feedback (#311 (comment)) into this branch.
There are now 3 export commands:
markdown.marp.exportAs
which will open a save dialog (as it is now)markdown.marp.exportQuick
which will quick export into the document directory with the file type being determined by the settingexportType
markdown.marp.exportToSelectedFormat
which will quick export into the document directory with the user being asked first for which file type should be usedThe old
markdown.marp.export
is mapped tomarkdown.marp.exportAs
for legacy/compatibility reasons.I did not touch the existing functions
doExport
andsaveDialog
.startExport
only exists to have a target for unit tests when callingexportQuick
orexportToSelectedFormat
.I also had to run
npm audit fix
to update two dependencies.Please note, I've not worked with
jest
before so the unit test may need improvement.