Support xunit v3 #804
Merged
Support xunit v3 #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for xunit v3 via the new MartinCostello.Logging.XUnit.v3 NuGet package. - Bump version to 0.5.0.
martincostello
added
enhancement
Closed
There was a problem hiding this comment.
Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
=======================================
Coverage 98.53% 98.53%
=======================================
Files 15 15
Lines 273 273
Branches 36 36
=======================================
Hits 269 269
Misses 2 2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ignore xunit.v3 updates for libraries used by the library.
Use `xunit.v3.extensibility.core` instead of `xunit.v3.common` and `xunit.v3.core` to resolve issues with the build.
Update the pinned xunit v3 packages.
Move all of the C# for the libraries into a Shared folder and link to each project from there.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Move properties back to Directory.Build.props.
Move all the code for the tests to a Shared folder for re-use.
The package will be released as 0.5.0, so validate against that.
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Refactor to make CodeQL happy.
Update README for new package.
Add a package icon (xunit's own logo).
There was a problem hiding this comment.
Copilot reviewed 31 out of 45 changed files in this pull request and generated no comments.
Files not reviewed (14)
- Directory.Build.props: Language not supported
- Directory.Packages.props: Language not supported
- Logging.XUnit.sln: Language not supported
- build.ps1: Language not supported
- src/Logging.XUnit.v3/MartinCostello.Logging.XUnit.v3.csproj: Language not supported
- src/Logging.XUnit/CompatibilitySuppressions.xml: Language not supported
- src/Logging.XUnit/MartinCostello.Logging.XUnit.csproj: Language not supported
- src/Shared/ITestOutputHelperAccessor.cs: Evaluated as low risk
- src/Shared/ITestOutputHelperExtensions.cs: Evaluated as low risk
- src/Shared/MessageSinkAccessor.cs: Evaluated as low risk
- src/Shared/StringSyntaxAttribute.cs: Evaluated as low risk
- src/Shared/TestOutputHelperAccessor.cs: Evaluated as low risk
- src/Shared/XUnitLogger.IMessageSink.cs: Evaluated as low risk
- src/Shared/IMessageSinkExtensions.cs: Evaluated as low risk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #717
TODO
Resolve TODOs aroundSelfRegisteredExtensions(see warning CS0436: The type ‘SelfRegisteredExtensions’ causes a conflict xunit/xunit#3036)Verify that the new library is indeed a library not an executable (see Library extending xunit v3 appears to be a test project - how to disable? xunit/xunit#3093)Update READMEEnsure that new package is included in NuGet publishing