Skip to content

fix(ipfs): retry transient HTTP errors in _uploadJSON via withRetry #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marvelousufelix wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(ipfs): retry transient HTTP errors in _uploadJSON via withRetry #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2c3f06
fix(ipfs): retry transient HTTP errors in _uploadJSON via withRetry
marvelousufelix Mar 27, 2026
96b7386
Merge branch 'main' into feat/implement-ipfs-pinata-service
marvelousufelix Mar 28, 2026
478cb39
feat: implement IPFS Pinata service
marvelousufelix Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions frontend/src/services/ipfs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,8 @@ export class IPFSService {
let response: Response
try {
response = await withRetry(
() =>
fetch(`${IPFS_CONFIG.pinataApiUrl}/pinning/pinJSONToIPFS`, {
async () => {
const res = await fetch(`${IPFS_CONFIG.pinataApiUrl}/pinning/pinJSONToIPFS`, {
method: 'POST',
headers: {
'Content-Type': 'application/json',
Expand All @@ -200,7 +200,17 @@ export class IPFSService {
}),
{ shouldRetry: isTransientError },
)
} catch {
} catch (err) {
// Re-throw IPFSUploadError as-is (shouldn't happen here, but be safe)
if (err instanceof IPFSUploadError) throw err
const status = (err as { status?: number }).status
if (status === undefined) {
// Pure network error
throw new IPFSUploadError(
'Network error during metadata upload. Check your connection and try again.'
)
}
// HTTP error that exhausted retries
throw new IPFSUploadError(
'Network error during metadata upload. Check your connection and try again.',
)
Expand Down
Loading
Loading