ci: add verify-web target and config filter to CI - #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracted CI workflow and Makefile changes from #345 without package or lockfile updates.
verify-webtarget to Makefile to build the web bundle and execute JavaScript files to catch circular dependencies / CJS interop bugs.ci-pr.ymlwith aconfigfilter (triggering on changes to config/lockfiles) and added aVerify Web Bundlestep undervalidate-mobile.expo-upgradein Makefile to passAPP_VERSION_NAMEtonpx expo install --check.Reasoning
Allows validating web bundle generation and circular dependency issues in CI without pulling in unnecessary package updates from #345.
Test Plan
make verify-weblocally or via CI on PR.