Skip to content

Fix Animated errors #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Animated errors #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
476ee00
Fix Animated errors
khofesh Oct 23, 2020
008f694
Update index.d.ts
khofesh Dec 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ActionButton.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ const ActionButton = props => {

useEffect(() => {
if (props.active) {
Animated.spring(anim.current, { toValue: 1 }).start();
Animated.spring(anim.current, { toValue: 1, useNativeDriver: false },).start();
setActive(true);
setResetToken(props.resetToken);
} else {
props.onReset && props.onReset();

Animated.spring(anim.current, { toValue: 0 }).start();
Animated.spring(anim.current, { toValue: 0, useNativeDriver: false }).start();
timeout.current = setTimeout(() => {
setActive(false);
setResetToken(props.resetToken);
Expand Down Expand Up @@ -254,7 +254,7 @@ const ActionButton = props => {
if (active) return reset(animate);

if (animate) {
Animated.spring(anim.current, { toValue: 1 }).start();
Animated.spring(anim.current, { toValue: 1, useNativeDriver: false }).start();
} else {
anim.current.setValue(1);
}
Expand All @@ -266,7 +266,7 @@ const ActionButton = props => {
if (props.onReset) props.onReset();

if (animate) {
Animated.spring(anim.current, { toValue: 0 }).start();
Animated.spring(anim.current, { toValue: 0, useNativeDriver: false }).start();
} else {
anim.current.setValue(0);
}
Expand Down
6 changes: 3 additions & 3 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import * as React from 'react'
import {
ViewStyle,
ViewProperties,
ViewProps,
TextStyle
} from 'react-native'


export interface ActionButtonProperties extends ViewProperties {
export interface ActionButtonProperties extends ViewProps {
resetToken?: any,
active?: boolean,

Expand Down Expand Up @@ -40,7 +40,7 @@ export interface ActionButtonProperties extends ViewProperties {
nativeFeedbackRippleColor?: string
}

export interface ActionButtonItemProperties extends ViewProperties {
export interface ActionButtonItemProperties extends ViewProps {
size?: number,
title?: string
onPress?: () => void
Expand Down