v8/client: add support for context cancellation#2
Open
johanbrandhorst wants to merge 1 commit intomatchaxnb:masterfrom
Open
v8/client: add support for context cancellation#2johanbrandhorst wants to merge 1 commit intomatchaxnb:masterfrom
johanbrandhorst wants to merge 1 commit intomatchaxnb:masterfrom
Conversation
Adds contexts to exported methods that may may make network requests to the KDC. The old timeout of 5 seconds for KDC requests has been maintained by adding a timeout to the old functions.
johanbrandhorst
commented
Jul 1, 2025
| module github.com/matchaxnb/gokrb5/v8 | ||
|
|
||
| go 1.16 | ||
| go 1.23.0 |
Author
There was a problem hiding this comment.
Go 1.23 is the oldest supported version of Go
johanbrandhorst
commented
Jul 1, 2025
| go 1.16 | ||
| go 1.23.0 | ||
|
|
||
| replace github.com/jcmturner/dnsutils/v2 => github.com/johanbrandhorst/dnsutils/v2 v2.0.0-20250626215550-85021c9d85c0 |
Author
There was a problem hiding this comment.
We can revert this back once (if?) jcmturner/dnsutils#6 is merged
johanbrandhorst
commented
Jul 1, 2025
Author
There was a problem hiding this comment.
This file is missing on master, looks like it was accidentally removed in 579e6ce
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds contexts to exported methods that may may make network requests to the KDC. The old timeout
of 5 seconds for KDC requests has been maintained by adding a timeout to the old functions.