Skip to content

add task solution#521

Open
AndrewPrszn wants to merge 6 commits intomate-academy:masterfrom
AndrewPrszn:develop
Open

add task solution#521
AndrewPrszn wants to merge 6 commits intomate-academy:masterfrom
AndrewPrszn:develop

Conversation

@AndrewPrszn
Copy link

@AndrewPrszn AndrewPrszn commented Sep 12, 2025

Copy link

@vitalii-bondarenko-ua vitalii-bondarenko-ua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
Needs some improvements.

  • Add favicon
  • Prevent resize textarea
Screenshot 2025-09-13 at 10 35 30 - Disable page scrolling under the menu. Screenshot 2025-09-13 at 10 36 02

Copy link

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!

  1. When I click on any link inside aside-menu, page should scroll to relevant section.
    Please add it and your solution will be approved!
image

Copy link

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No fix - I've chosen a Contacts link from aside menu, but the page haven't scrolled yet:
image

Please fix it

Copy link

@vitalii-bondarenko-ua vitalii-bondarenko-ua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments