Skip to content

Comments

solution#213

Open
xnquaint wants to merge 5 commits intomate-academy:masterfrom
xnquaint:develop
Open

solution#213
xnquaint wants to merge 5 commits intomate-academy:masterfrom
xnquaint:develop

Conversation

@xnquaint
Copy link

@xnquaint
Copy link
Author

no hover scale on header logo and bucket. did it on purpose cause it makes no sense imho

Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job overall! Just one tiny thing needs to be fixed before approval)

remove _blank for prevent blink page
image

@xnquaint
Copy link
Author

removed from footer__links*

@xnquaint xnquaint requested a review from maxim2310 March 19, 2024 19:39
Copy link

@DarkMistyRoom DarkMistyRoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Here are a few suggestions for improvement:

  • would be great to add a hover effect to these links
image
  • check these geometrical background elements. They should stick to the left side
image
  • open the socials on a new page
image
  • change the year to 2024
image
  • these dynamic blocks overlap the buttons on tab screen
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants