Open
Conversation
loralevitska
suggested changes
Apr 21, 2024
loralevitska
left a comment
loralevitska
left a comment
There was a problem hiding this comment.
You did an amazing job! Looks good! Let's do some improvements (check comments)
- logo should be a link
- add indents between words
- add cursor pointer to all clickable elements on page, for example such buttons
- make these guys links (map open in new tab)
- remove default background color after autocomplete
- social icons should be links with appropriate link address
- fix this footer according mockup
- add hover effect to these links
- fix these parts according mockup
- change to 2024
nazarmatsevych
suggested changes
Apr 21, 2024
nazarmatsevych
left a comment
nazarmatsevych
left a comment
There was a problem hiding this comment.
Previous comments were not fixed. Maybe you forgot to rerun "npm run deploy" command?
If you have any questions - feel free to ask them in fe_chat
Author
i havent noticed script fail, now should be ok |
Author
|
SanyaBratashchuk
suggested changes
Apr 21, 2024
SanyaBratashchuk
left a comment
SanyaBratashchuk
left a comment
There was a problem hiding this comment.
- Get rid of horizontal scroll
- form should be reset after submit
SanyaBratashchuk
approved these changes
Apr 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEMO LINK