-
Notifications
You must be signed in to change notification settings - Fork 198
Tests for a arrayReverse function #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
r-marianna
wants to merge
3
commits into
mate-academy:main
Choose a base branch
from
r-marianna:develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,13 +8,49 @@ describe(`Function 'arrayReverse':`, () => { | |
| }); | ||
|
|
||
| it(`should return an array`, () => { | ||
|
|
||
| expect(arrayReverse(['Mate'])).toBeInstanceOf(Array); | ||
| }); | ||
|
|
||
| it(`should return an empty string | ||
| if original array consists of an empty string`, () => { | ||
| expect(arrayReverse(['Mate', 'Academy'])).toEqual(['ymed', 'acAetaM']); | ||
| expect(arrayReverse([''])).toEqual(['']); | ||
| }); | ||
|
|
||
| it('should return the reversed string', () => { | ||
| expect(arrayReverse(['Hell0'])).toEqual(['0lleH']); | ||
| }); | ||
|
|
||
| it( | ||
| 'should reverse both the order of the strings and ' + | ||
| 'the characters within each string', | ||
| () => { | ||
| expect(arrayReverse(['Mate', 'Academy'])).toEqual(['ymed', 'acAetaM']); | ||
| } | ||
| ); | ||
|
|
||
| it('should reverse more than one string', () => { | ||
| expect(arrayReverse(['I', 'am', 'a', 'student!'])).toEqual([ | ||
| '!', | ||
| 'tn', | ||
| 'e', | ||
| 'dutsamaI', | ||
|
Comment on lines
+32
to
+36
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Issue: The expected output for this test case does not match the required behavior. The function should reverse the order of the strings and also reverse the characters in each string. Please update the expected result accordingly. |
||
| ]); | ||
| }); | ||
|
|
||
| // write more tests here | ||
| it( | ||
| 'should reverse both the order of the strings' + | ||
| 'and the characters within each string', | ||
| () => { | ||
| expect(arrayReverse(['I', 'stude'])).toEqual(['e', 'dutsI']); | ||
| } | ||
| ); | ||
| }); | ||
|
|
||
| /* | ||
| Examples: | ||
|
|
||
| ```js | ||
| arrayReverse(['Hell0']) === ['0lleH']; | ||
| arrayReverse(['Mate', 'Academy']) === ['ymed', 'acAetaM']; | ||
| arrayReverse(['I', 'am', 'a', 'student!']) === ['!', 'tn', 'e', 'dutsamaI']; | ||
| */ | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: The expected output for this test case does not seem to align with the likely intended behavior of an array reverse function. If the function is supposed to reverse the order of the strings and also reverse each string, the expected output should be ['!tneduts', 'a', 'ma', 'I']. Please verify the requirements and adjust the expected output accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Examples: