Skip to content

add task solution#2195

Open
nikassafronovs wants to merge 1 commit intomate-academy:masterfrom
nikassafronovs:develop
Open

add task solution#2195
nikassafronovs wants to merge 1 commit intomate-academy:masterfrom
nikassafronovs:develop

Conversation

@nikassafronovs
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on the JavaScript implementation! The logic for parsing the data, performing the calculations, and updating the DOM is correct and well-written. However, changes are needed because your submission modifies files that were explicitly excluded by the task instructions. The task required that only the src/scripts/main.js file be changed. Please revert the modifications made to src/styles/_fonts.scss and src/styles/main.scss. Once your pull request only contains the changes to main.js, I will be happy to approve it.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

@nikassafronovs
Copy link
Author

@mateacademy-ai-mentor3.

I don't know what I need to fix in src/styles/_fonts.scss and src/styles/main.scss because I didn't make any changes there.

Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants