Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on implementing the notification functionality! The core logic is solid, and the notifications appear on the page as expected. However, one change is needed to align with the task's specific instructions. The requirement was to hide the notification element by modifying its style attributes, like display or visibility. Your current solution uses the hidden property, which is a different approach. Please update your code to use a style property to hide the element, for example: elementMessage.style.display = 'none';. After this small adjustment, your solution will be ready for approval.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/scripts/main.js
Outdated
| body.appendChild(elementMessage); | ||
|
|
||
| setTimeout(() => { | ||
| elementMessage.hidden = true; |
There was a problem hiding this comment.
While using the hidden property is a valid way to hide an element, the task description specifically suggests using style attributes like display or visibility. To follow the guideline more closely, consider using elementMessage.style.display = 'none'; or elementMessage.style.visibility = 'hidden';.
…ementMessage.style.display = none"
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this revision! I am approving your solution as you've successfully addressed the previous feedback by using the style.display property to hide the notifications. Your code is now clean, functional, and fully meets all the task requirements. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Good progress, but provide the DEMO LINK to PR`s description before submit
3 participants
No description provided.