Skip to content

solution#1786

Open
Alternate001 wants to merge 2 commits intomate-academy:masterfrom
Alternate001:master
Open

solution#1786
Alternate001 wants to merge 2 commits intomate-academy:masterfrom
Alternate001:master

Conversation

@Alternate001
Copy link
Copy Markdown

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

This requires a small change before it can be approved. You've done a great job implementing the core functionality for creating, positioning, and hiding the notifications. However, the automated tests are failing because the h2 title element is missing its required title class. The task description specifies that this class must be present.

You can easily fix this by adding the class to the title element after you create it, for example:

titleText.classList.add('title');

Once you make this change, the tests should pass. You are very close to completing the task!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example


const pushNotification = (posTop, posRight, title, description, type) => {
// write code here
const titleText = document.createElement('h2');
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task description requires the title element to have a title class. This class has not been added to the h2 element.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this task! I'm happy to approve your solution. You've successfully addressed the feedback from the last review by adding the required title class to the heading element. Your implementation now meets all the requirements perfectly, and the notifications function just as specified. Keep up the fantastic work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants