Skip to content

add task solution#1796

Open
timurradkevic wants to merge 1 commit intomate-academy:masterfrom
timurradkevic:develop
Open

add task solution#1796
timurradkevic wants to merge 1 commit intomate-academy:masterfrom
timurradkevic:develop

Conversation

@timurradkevic
Copy link
Copy Markdown

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this task! Your solution correctly creates, displays, and hides the notifications, meeting all the core requirements. The code is clean and functions perfectly, so I am approving your submission.

As a minor point for future reference, the task guidelines suggested using style attributes like display or visibility to hide the element. While message.hidden = true works and achieves the desired outcome, a more direct implementation would be to set the style property, for example: message.style.display = 'none';. This is just a suggestion to align more closely with the instructions and not a required change.

Great job overall!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment thread src/scripts/main.js

message.append(titl, desc);
body.appendChild(message);
setTimeout(() => (message.hidden = true), 2000);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This successfully hides the element. However, the task requirements specifically mention using 'style attributes... (f.e, display or visibility properties)'. While element.hidden = true works by setting display: none via the browser's stylesheet, a more direct way to follow the instructions would be to set the style property directly, for example: message.style.display = 'none';.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants