Conversation
GabrielSpelchuk
commented
Feb 20, 2026
GabrielSpelchuk
commented
- DEMO LINK
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job setting up the two promises with the correct logic for resolving and rejecting them. However, this submission requires changes because a core requirement was not met. The task specifies that both promises must have success (.then()) and error (.catch()) handlers.
Currently, promise1 is missing its .catch() handler, and promise2 is missing its .then() handler. Please add the missing handlers to each promise chain to ensure all possible outcomes are handled correctly. Once that's done, this solution will be perfect!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/scripts/main.js
Outdated
| promise1.then(() => { | ||
| const div = document.createElement('div'); | ||
|
|
||
| div.classList.add('message'); | ||
| div.textContent = 'Promise was resolved!'; | ||
| body.appendChild(div); | ||
| }); |
There was a problem hiding this comment.
According to the task description, you need to add both success and error handlers for each promise. This promise chain is missing an error handler (.catch()).
src/scripts/main.js
Outdated
| promise2.catch((errorMessage) => { | ||
| const div = document.createElement('div'); | ||
|
|
||
| div.classList.add('message'); | ||
| div.classList.add('error-message'); | ||
| div.textContent = errorMessage.message; | ||
| body.appendChild(div); | ||
| }); |
There was a problem hiding this comment.
The requirements state that you should add both success and error handlers for each promise. This promise chain is missing a success handler (.then()).
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this pull request! You've successfully addressed the feedback from the previous review by adding the required success and error handlers. The implementation is now solid, and the code fully meets all the task requirements. I'm happy to approve your submission. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
