Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on this task! You've correctly set up both promises and handled the logic for promise2 perfectly. However, this submission requires a small change before it can be approved. The task description specifies that both promise1 and promise2 must have both success (.then()) and error (.catch()) handlers. Your code for promise1 is currently missing the required .catch() block. Please add the error handler to promise1 to fully meet the requirements.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/scripts/main.js
Outdated
| promise1.then(() => { | ||
| const div = document.createElement('div'); | ||
|
|
||
| div.classList.add('message'); | ||
| div.textContent = 'Promise was resolved!'; | ||
| body.append(div); | ||
| }); |
There was a problem hiding this comment.
According to the task description, you need to add both success and error handlers for promise1 and promise2. While promise1 has a success handler (.then()), it's missing the required error handler (.catch()).
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work! You've successfully addressed the feedback from the previous review by adding the missing error handler to promise1. The code now fully meets all the task requirements. Both promises are set up correctly, and their respective success and error handlers behave as expected. I am happy to approve your solution. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.