Conversation
| break; | ||
|
|
||
| default: | ||
| return "Error: Type Unknown"; |
There was a problem hiding this comment.
In the 'default' case of your switch statement, you are returning a string. This will end the execution of the function, even if there are more valid actions in the 'actions' array. Instead, consider logging the error or ignoring the action with an invalid type.
| function transformState(state, actions) { | ||
| // write code here | ||
| for (const action of actions) { | ||
| const { type, extraData, keysToRemove } = action; |
There was a problem hiding this comment.
The destructuring of 'action' assumes that every action object has 'extraData' and 'keysToRemove' properties. This can potentially cause 'undefined' errors if these properties are absent. Consider destructuring these properties inside their respective case blocks.
| } | ||
| break; | ||
|
|
||
| case "clear": |
There was a problem hiding this comment.
However, there is a small issue with the "clear" case. When you want to clear all properties from the state object, using a for...in loop may not work as expected. Instead, you should use Object.keys to get an array of keys and then delete each key.
3 participants
No description provided.