Skip to content

add task solution #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RHerheman wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution #1705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions src/scripts/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,32 @@
'use strict';

document.addEventListener('click', (e) => {
// write code here
// eslint-disable-next-line no-shadow
document.addEventListener('click', (event) => {
const wall = document.querySelector('.wall');
const spider = document.querySelector('.spider');

if (event.target !== wall && event.target !== spider) {
return;
}

const wallRect = wall.getBoundingClientRect();
const spiderRect = spider.getBoundingClientRect();
const spiderW = spiderRect.width;
const spiderH = spiderRect.height;
const borderWidth = parseInt(getComputedStyle(wall).borderLeftWidth);
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line assumes all borders of the wall have the same width as the left border. This will cause incorrect positioning if, for example, border-top-width is different. The clickY calculation on line 19 and the boundary calculations on lines 23 and 27 will be wrong. It's better to get each border width property (borderTopWidth, borderRightWidth, borderBottomWidth) and use them in their respective calculations.


const clickX = event.clientX - wallRect.left - borderWidth;
const clickY = event.clientY - wallRect.top - borderWidth;

const x = Math.min(
Math.max(clickX - spiderW / 2, 0),
wallRect.width - spiderW - borderWidth * 2,
);
const y = Math.min(
Math.max(clickY - spiderH / 2, 0),
wallRect.height - spiderH - borderWidth * 2,
);

spider.style.left = `${x}px`;
spider.style.top = `${y}px`;
});
Loading