Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on calculating the age and century values and dynamically creating the table rows. The main logic is implemented correctly. However, one change is needed before this can be approved. The columns in the generated table do not follow the required order: name, gender, born, died, age, century. Currently, the gender column is misplaced, which causes the data in the table to be misaligned with the headers. Please adjust the order in which you create the table cells to ensure they match the specified sequence. After that small fix, your solution will be perfect!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| const gender = person.sex === 'm' ? 'Male' : 'Female'; | ||
|
|
||
| // порядок колонок для тесту | ||
| const cells = [person.name, person.born, person.died, age, gender, century]; |
There was a problem hiding this comment.
The order of the columns in this array does not match the order required by the task (name, gender, born, died, age, century). Currently, gender is displayed after age, but it should be the second column.
There was a problem hiding this comment.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
vitalii-bondarenko-ua
left a comment
vitalii-bondarenko-ua
left a comment
There was a problem hiding this comment.
Good job.
Please check comments and try to pass tests.
Provide demo link to PR description.
| const gender = person.sex === 'm' ? 'Male' : 'Female'; | ||
|
|
||
| // порядок колонок для тесту | ||
| const cells = [person.name, person.born, person.died, age, gender, century]; |
There was a problem hiding this comment.
| // правильно визначаємо стать | ||
| const gender = person.sex === 'm' ? 'Male' : 'Female'; | ||
|
|
||
| // порядок колонок для тесту |
There was a problem hiding this comment.
general practice to write coments in English. All comments looks like redundant, code should be understandable without comments...
3 participants
No description provided.