Skip to content

feat: info in table for people data#1758

Open
dmytro-halieba wants to merge 2 commits intomate-academy:masterfrom
dmytro-halieba:develop
Open

feat: info in table for people data#1758
dmytro-halieba wants to merge 2 commits intomate-academy:masterfrom
dmytro-halieba:develop

Conversation

@dmytro-halieba
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great work on the core logic for this task! The calculations for age and century are spot on, and you've done a nice job of dynamically creating and appending the table rows.

However, one change is needed to fully meet the project requirements. The task specifies that the table must be selected using its class dashboard. Your current implementation uses getElementsByTagName('table')[0], which doesn't follow this specific instruction.

Please update your code to use a class-based selector like document.querySelector('.dashboard') to target the correct element. After that small fix, your solution will be perfect!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this pull request! You've successfully addressed the feedback from the previous review by using document.querySelector to select the table. Your code is now clean, functional, and fully meets all the requirements of the task. I am approving your solution. Keep up the great work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants