Skip to content

task complete#1759

Open
Dimononon wants to merge 3 commits intomate-academy:masterfrom
Dimononon:dev
Open

task complete#1759
Dimononon wants to merge 3 commits intomate-academy:masterfrom
Dimononon:dev

Conversation

@Dimononon
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

This is a great solution and all the core logic for generating the table and calculating the values is implemented correctly! However, one small change is needed to perfectly match the task requirements.

In src/scripts/main.js, the output for the gender column doesn't quite match the reference.png image. The reference shows the gender in all lowercase (e.g., male), but your code currently displays it with capitalization (e.g., Male).

Please update your code to convert the gender value to lowercase before adding it to the table cell. After that small fix, this will be ready for approval!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this pull request! You've successfully addressed the feedback from the previous review, and the code now perfectly meets all requirements. The gender is correctly displayed in lowercase, and the table generation logic is clean and correct. This solution is in great shape, and I'm happy to approve it. Well done!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants