Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on implementing the recursive createTree function! The overall logic is well-structured and works correctly for the provided test case.
However, this requires a change because there's a potential runtime error. In src/scripts/main.js, the condition to check for a nested object is not safe. If a property's value is a truthy primitive (like a number or a string), Object.keys() will be called on it and throw a TypeError, crashing the script.
To fix this, please update the condition to first check if the value is an object before attempting to get its keys. A check like typeof data[key] === 'object' && data[key] !== null would be a more robust way to prevent this error. After you address this, it will be ready for approval!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/scripts/main.js
Outdated
|
|
||
| li.textContent = key; | ||
|
|
||
| if (data[key] && Object.keys(data[key]).length > 0) { |
There was a problem hiding this comment.
This condition is not safe. If data[key] is a truthy primitive value (e.g., a number like 1 or a non-empty string), Object.keys(data[key]) will throw a TypeError because these values are not objects. You should first check if data[key] is an object before attempting to get its keys. A check like typeof data[key] === 'object' && data[key] !== null would be more appropriate.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this iteration! I am happy to approve your solution. You've successfully addressed the previous feedback, and the check for nested objects is now robust, preventing any TypeError. The recursive logic is well-implemented and the project structure is correct. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.