Skip to content

Solution #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shvxmlk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 41 additions & 1 deletion src/scripts/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,47 @@ const food = {
const tree = document.querySelector('#tree');

function createTree(element, data) {
// WRITE YOUR CODE HERE
const ul = document.createElement('ul');

for (const key in data) {
const li = document.createElement('li');
li.textContent = key;

const children = createSubTree(data[key]);

if (children) {
li.appendChild(children);
}

ul.appendChild(li);
}

element.appendChild(ul);
}
Comment on lines 23 to +40
Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic inside this for...in loop (lines 26-37) is almost identical to the logic inside the forEach loop in the createSubTree function (lines 51-62). This is code duplication.

The createSubTree function is already capable of building the entire tree structure. You can simplify this createTree function to just call createSubTree(data) and then append the resulting <ul> element to the element container. This avoids repeating code and makes the recursive nature of the solution clearer.


function createSubTree(obj) {
const keys = Object.keys(obj);

if (!keys.length) {
return null;
}

const ul = document.createElement('ul');

keys.forEach(key => {
const li = document.createElement('li');
li.textContent = key;

const children = createSubTree(obj[key]);

if (children) {
li.appendChild(children);
}

ul.appendChild(li);
});

return ul;
}

createTree(tree, food);
Loading