Hometask jv-web-practice completed#660
Open
MarynaKushniruk wants to merge 3 commits intomate-academy:masterfrom
Open
Hometask jv-web-practice completed#660MarynaKushniruk wants to merge 3 commits intomate-academy:masterfrom
MarynaKushniruk wants to merge 3 commits intomate-academy:masterfrom
Conversation
kozhukhovsky
suggested changes
Aug 6, 2023
| } | ||
|
|
||
| @Override | ||
| protected void doPost(HttpServletRequest req, HttpServletResponse resp) |
| car.setManufacturer(manufacturer); | ||
| car.setDrivers(new ArrayList<>()); | ||
| carService.create(car); | ||
| resp.sendRedirect("/index"); |
okuzan
suggested changes
Aug 7, 2023
| Driver driver = driverService.get(Long.valueOf(req.getParameter("driver"))); | ||
| car.getDrivers().add(driver); | ||
| carService.update(car); | ||
| resp.sendRedirect(req.getContextPath() + "/cars/add/driver"); |
There was a problem hiding this comment.
better redirect to a page where you can see the change just made, after you added a car - to list of all cars etc
Comment on lines
26
to
29
| protected void doPost(HttpServletRequest req, HttpServletResponse resp) | ||
| throws ServletException, IOException { | ||
| resp.sendRedirect(req.getContextPath() + "/cars/all"); | ||
| } |
There was a problem hiding this comment.
remove doPost from controllers that start with Get
olekskov
approved these changes
Aug 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.