added controllers & appropriate jsp pages#663
Open
TemkaHillfinger wants to merge 4 commits intomate-academy:masterfrom
Open
added controllers & appropriate jsp pages#663TemkaHillfinger wants to merge 4 commits intomate-academy:masterfrom
TemkaHillfinger wants to merge 4 commits intomate-academy:masterfrom
Conversation
okuzan
suggested changes
Aug 7, 2023
| Car car = carService.get(carId); | ||
| Driver driver = driverService.get(driverId); | ||
| carService.addDriverToCar(driver, car); | ||
|
|
There was a problem hiding this comment.
add redirect to the page where you can see the change just made (all cars after adding a car etc)
…cars after adding a car)
olekskov
suggested changes
Aug 8, 2023
| car.setModel(req.getParameter("model")); | ||
| car.setManufacturer(manufacturerService.get(manufacturerId)); | ||
| car.setDrivers(new ArrayList<>()); | ||
| carService.create(car); |
There was a problem hiding this comment.
Same as Oleh commented before. After all doPost method we should redirect user to page where he may see result of his request (list of all cars, drivers etc) otherwise he will struggle to understand if his request is successful.
Please recheck all controllers for same issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.