Conversation
TomekSzatal
commented
Feb 13, 2026
- DEMO LINK
- TEST REPORT LINK
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on the overall structure and use of SCSS features like variables and @each! However, a few key requirements were missed, so I'm requesting some changes.
Here are the points to address:
- Day Numbering: The task requires using a SASS
@forloop to generate the numbers for the days. Your current solution uses CSS counters (counter-resetandcounter-increment), which should be replaced. You'll need to create a loop from 1 to 31 that sets thecontentproperty for each day's::beforepseudo-element using an:nth-childselector. - Day Sizing: Each day should be a
100pxsquare including its1pxborder. Currently, the total size is102pxx102px. Please addbox-sizing: border-box;to your.calendar__daystyles to fix this. - HTML Markup: The
index.htmlfile only contains 30.calendar__dayelements, but the requirement is for 31. - File Naming: The stylesheet must be named
main.scss. Please renamesrc/styles/index.scssand update the<link>tag in your HTML accordingly.
Once these items are corrected, your solution will be ready for approval. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/styles/index.scss
Outdated
| width: calc( | ||
| (#{$columns} * #{$day-size}) + (#{$gap} * (#{$columns} - 1)) + (#{$calendar-padding} * 2) | ||
| ); | ||
| counter-reset: day; |
There was a problem hiding this comment.
The task requires generating day numbers using a SASS @for loop, not CSS counters. Please remove counter-reset (here), counter-increment (on line 54), and content: counter(day) (on line 57). Instead, implement the numbering with a @for loop that iterates from 1 to 31, targets each day using :nth-child, and sets the content of the ::before pseudo-element.
src/styles/index.scss
Outdated
| width: $day-size; | ||
| height: $day-size; | ||
| background-color: $day-bg; | ||
| border: $border-width solid $border-color; |
There was a problem hiding this comment.
The requirement is for each day to be a '100px square (including 1px black border)'. This means the total size of the element, border included, should be 100x100px. Currently, the element's total size is 102x102px (100px content + 2px border). To fix this, you need to add the box-sizing: border-box; property. This will also ensure your calendar's total width calculation on line 35 works correctly.
src/index.html
Outdated
| @@ -12,7 +12,45 @@ | |||
| href="styles/index.scss" | |||
There was a problem hiding this comment.
The task description requires the stylesheet to be named main.scss. Please update the href attribute here and rename your SCSS file accordingly.
src/index.html
Outdated
| <section class="calendar calendar--sun calendar--31"> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
|
|
||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
|
|
||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
|
|
||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
|
|
||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| </section> |
There was a problem hiding this comment.
The task requires creating markup for 31 days, but there are only 30 .calendar__day elements within this section.
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this task! You've successfully addressed all the feedback from the previous review, and the project now meets all requirements perfectly. Your implementation of SCSS is fantastic, especially the clean use of variables, @for, and @each loops to create a dynamic and maintainable stylesheet. The calendar is fully responsive to the modifier classes, and all styling and animation requirements are correctly implemented. I am approving your solution, great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨