Skip to content

Comments

add task solution#5192

Draft
TomekSzatal wants to merge 2 commits intomate-academy:masterfrom
TomekSzatal:develop
Draft

add task solution#5192
TomekSzatal wants to merge 2 commits intomate-academy:masterfrom
TomekSzatal:develop

Conversation

@TomekSzatal
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great job on the overall structure and use of SCSS features like variables and @each! However, a few key requirements were missed, so I'm requesting some changes.

Here are the points to address:

  1. Day Numbering: The task requires using a SASS @for loop to generate the numbers for the days. Your current solution uses CSS counters (counter-reset and counter-increment), which should be replaced. You'll need to create a loop from 1 to 31 that sets the content property for each day's ::before pseudo-element using an :nth-child selector.
  2. Day Sizing: Each day should be a 100px square including its 1px border. Currently, the total size is 102px x 102px. Please add box-sizing: border-box; to your .calendar__day styles to fix this.
  3. HTML Markup: The index.html file only contains 30 .calendar__day elements, but the requirement is for 31.
  4. File Naming: The stylesheet must be named main.scss. Please rename src/styles/index.scss and update the <link> tag in your HTML accordingly.

Once these items are corrected, your solution will be ready for approval. Keep up the great work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

width: calc(
(#{$columns} * #{$day-size}) + (#{$gap} * (#{$columns} - 1)) + (#{$calendar-padding} * 2)
);
counter-reset: day;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task requires generating day numbers using a SASS @for loop, not CSS counters. Please remove counter-reset (here), counter-increment (on line 54), and content: counter(day) (on line 57). Instead, implement the numbering with a @for loop that iterates from 1 to 31, targets each day using :nth-child, and sets the content of the ::before pseudo-element.

Comment on lines 40 to 43
width: $day-size;
height: $day-size;
background-color: $day-bg;
border: $border-width solid $border-color;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirement is for each day to be a '100px square (including 1px black border)'. This means the total size of the element, border included, should be 100x100px. Currently, the element's total size is 102x102px (100px content + 2px border). To fix this, you need to add the box-sizing: border-box; property. This will also ensure your calendar's total width calculation on line 35 works correctly.

src/index.html Outdated
@@ -12,7 +12,45 @@
href="styles/index.scss"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task description requires the stylesheet to be named main.scss. Please update the href attribute here and rename your SCSS file accordingly.

src/index.html Outdated
Comment on lines 18 to 53
<section class="calendar calendar--sun calendar--31">
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>

<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>

<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>

<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>

<div class="calendar__day"></div>
<div class="calendar__day"></div>
</section>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task requires creating markup for 31 days, but there are only 30 .calendar__day elements within this section.

@TomekSzatal TomekSzatal marked this pull request as draft February 13, 2026 12:25
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this task! You've successfully addressed all the feedback from the previous review, and the project now meets all requirements perfectly. Your implementation of SCSS is fantastic, especially the clean use of variables, @for, and @each loops to create a dynamic and maintainable stylesheet. The calendar is fully responsive to the modifier classes, and all styling and animation requirements are correctly implemented. I am approving your solution, great job!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants