Conversation
Anastasiia-Svintsova
left a comment
There was a problem hiding this comment.
Good start! Improve the code readability according to my comments and check the checklist one more time.
src/index.html
Outdated
| <form | ||
| action="https://mate-academy-form-lesson.herokuapp.com/create-application" | ||
| method="post"> |
There was a problem hiding this comment.
| <form | |
| action="https://mate-academy-form-lesson.herokuapp.com/create-application" | |
| method="post"> | |
| <form | |
| action="https://mate-academy-form-lesson.herokuapp.com/create-application" | |
| method="post" | |
| > |
| </legend> | ||
| <label class="field"> |
There was a problem hiding this comment.
Don't forget to add empty lines between multiline sibling blocks of HTML
| </legend> | |
| <label class="field"> | |
| </legend> | |
| <label class="field"> |
src/index.html
Outdated
| name="answer" | ||
| value="Yes" | ||
| > | ||
| <label for="yes"> |
There was a problem hiding this comment.
Fix the labels here. It doesn't work correctly for now
Screen.Recording.2023-06-01.at.14.00.14.mov
There was a problem hiding this comment.
Hi @Anastasiia-Svintsova about this part I do not understand what I have to do? It's giving only one choice yes or no, do I have to change both to be selected? Please explain to me and thanks for your suggestions :)
src/index.html
Outdated
| <button class="frame" | ||
| type="submit" | ||
| name="submit"> |
There was a problem hiding this comment.
| <button class="frame" | |
| type="submit" | |
| name="submit"> | |
| <button | |
| class="frame" | |
| type="submit" | |
| name="submit" | |
| > |
Anastasiia-Svintsova
left a comment
There was a problem hiding this comment.
Hey! Pay attention to my comments and fix the code style, please
src/index.html
Outdated
| </head> | ||
| <body> | ||
| <h1>HTML Form</h1> | ||
| <!-- <h1>HTML Form</h1> --> |
| > | ||
|
|
||
| <fieldset class="frame"> |
There was a problem hiding this comment.
Don't. add spaces between parent and child components
| > | |
| <fieldset class="frame"> | |
| > | |
| <fieldset class="frame"> |
| > | ||
|
|
||
| </label> |
There was a problem hiding this comment.
Fix it everywhere
| > | |
| </label> | |
| > | |
| </label> |
src/index.html
Outdated
| <label class="field"> | ||
| Do you love cats? |
There was a problem hiding this comment.
These radio buttons still don't work correctly. Test it more carefully, please. Ask questions in the chat if you need to
Screen.Recording.2023-06-02.at.13.55.45.mov
src/index.html
Outdated
| <select name="cars" | ||
| id="cars" multiple> |
There was a problem hiding this comment.
Check the code style
| <select name="cars" | |
| id="cars" multiple> | |
| <select | |
| name="cars" | |
| id="cars" | |
| multiple | |
| > |
https://nenatre.github.io/layout_html-form/
https://nenatre.github.io/layout_html-form/report/html_report/