add test solution by arturgorniak · Pull Request #800 · mate-academy/layout_html-form

arturgorniak · 2023-06-05T17:04:10Z

https://arturgorniak.github.io/layout_html-form/
https://arturgorniak.github.io/layout_html-form/report/html_report/

mkyloa

test

mkyloa

test

DorotaLeniecDev

Fix HTML formating and remove unnecessary class names

DorotaLeniecDev · 2023-06-06T14:09:26Z

src/index.html

+    <meta name="viewport"
+    content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0"


Fix formatting

Suggested change

<meta name="viewport"

content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0"

<meta

name="viewport"

content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0"

>

DorotaLeniecDev · 2023-06-06T14:11:23Z

src/index.html

+
  <body>
-    <h1>HTML Form</h1>
+


Spaces between parent and child are not needed, remove

DorotaLeniecDev · 2023-06-06T14:12:23Z

src/index.html

+    <form action="https://mate-academy-form-lesson.herokuapp.com/create-application"
+    method="post" name="personal-information">


Fiz formatting:
Also name should be camelCase

Suggested change

<form action="https://mate-academy-form-lesson.herokuapp.com/create-application"

method="post" name="personal-information">

<form

action="https://mate-academy-form-lesson.herokuapp.com/create-application"

method="post"

name="personal-information"

>

DorotaLeniecDev · 2023-06-06T14:13:55Z

src/index.html

+          <label for="surname">Surname:
+            <input
+            type="text"
+            autocomplete="off"
+            id="surname"
+            name="surname"
+            >
+          </label>


Fix formatting:

Suggested change

<label for="surname">Surname:

<input

type="text"

autocomplete="off"

id="surname"

name="surname"

>

</label>

<label for="surname">

Surname:

<input

type="text"

autocomplete="off"

id="surname"

name="surname"

>

</label>

DorotaLeniecDev · 2023-06-06T14:14:16Z

src/index.html

+        </div>
+
+        <div class="input name">
+          <label for="name">Name:


Same here, check all documnent and fix formatting

DorotaLeniecDev · 2023-06-06T14:15:06Z

src/index.html

+            >
+          </label>
+        </div>
+


remove line

DorotaLeniecDev · 2023-06-06T14:17:41Z

src/index.html

+            <input
+            type="radio"
+            name="cats"
+            id="cats yes"


Do not add two ids, you can use for example catLoverYes

DorotaLeniecDev · 2023-06-06T14:18:06Z

src/index.html

+
+        <div class="input cars">
+          <label for="cars">What are your favorite brand of cars?
+            <select


Fix formatting

DorotaLeniecDev · 2023-06-06T14:19:32Z

src/index.html

+    <form action="https://mate-academy-form-lesson.herokuapp.com/create-application"
+    method="post" name="personal-information">
+
+      <fieldset class="form-field personal-information">


You dont need additional classes for fieldset, remove in whole HTML and use only form-field class, I would suggest to rename it to form-fieldset for consistancy

DorotaLeniecDev · 2023-06-06T14:20:13Z

src/index.html

+
+      <fieldset class="form-field personal-information">
+        <legend>Personal information</legend>
+        <div class="input surname">


Same here, use single class for styling input container and name class more descriptively like form-field

arturgorniak · 2023-06-06T16:15:56Z

I made changes as suggested, it should be fine now.

darokrk

Please fix code indentations in whole file and we are ready to go 👍🏽

darokrk · 2023-06-09T06:38:01Z

src/index.html

+
  <body>
-    <h1>HTML Form</h1>
+    <form


Please fix the formatting of the code. You have to use the correct code indentations.

Look Dorota's mentions before and apply it in the whole code :)

<form action="https://mate-academy-form-lesson.herokuapp.com/create-application" method="post" name="personalInformation" >

arturgorniak · 2023-06-09T14:40:52Z

done

DorotaLeniecDev

Few more and we are good to go

DorotaLeniecDev · 2023-06-12T11:14:20Z

src/index.html

+    <meta
+      charset="UTF-8"
+    >


Overall when there is less than 3 attributes in a tag there is no need for spreading it into several lines. We do it when the attribute list is long for readability so this should simply be:

Suggested change

<meta

charset="UTF-8"

>

<meta charset="UTF-8">

DorotaLeniecDev · 2023-06-12T11:16:53Z

src/index.html

+      content="width=device-width, user-scalable=no, initial-scale=1.0,
+      maximum-scale=1.0, minimum-scale=1.0"


Dont spread attribute value, put it in a one line

Suggested change

content="width=device-width, user-scalable=no, initial-scale=1.0,

maximum-scale=1.0, minimum-scale=1.0"

content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0"

DorotaLeniecDev · 2023-06-12T11:19:42Z

src/index.html

+            <input
+              type="radio"
+              name="cats"
+              id="catsYes"
+            >
+            Yes
+
+            <input
+              type="radio"
+              name="cats"
+              id="catsNo"
+            >
+            No


Make Yes and No values a clicable lables so it focuses on the correct input when clicked

DorotaLeniecDev · 2023-06-12T11:21:11Z

src/index.html

+          <label for="cars">
+            What are your favorite brand of cars?
+
+            <select


Fix formating for this select tag, add indentations

DorotaLeniecDev · 2023-06-12T11:22:15Z

src/index.html

+              name="cars"
+              id="cars"
+              multiple>


Fix formating for this select tag, add indentations like:

Suggested change

name="cars"

id="cars"

multiple>

<select

name="cars"

id="cars"

multiple

>

DorotaLeniecDev · 2023-06-12T11:22:39Z

src/index.html

+            type="submit"
+            value="Submit"
+          >
+


remove empty line

arturgorniak · 2023-06-23T15:04:45Z

Finally i had some time to fix this. Can i also please to run tests for hello world task?
https://github.com/arturgorniak/layout_hello-world

arturgorniak added 20 commits June 5, 2023 13:14

adding 4 main divs

bce2a57

first div expansion

72b6e94

first div styles

7933253

second div content and styles

77de9ae

third div content and styles

91b4740

final div content and styles

b9210f1

eslint changes

7a73752

eslint changes

cfca282

eslint changes

408adf7

eslint changes

a43e737

eslint changes

16b34b6

eslint changes

40e893e

eslint changes

0e3acb9

eslint changes

637eab5

eslint changes

d1de9e3

eslint changes

0a5b8a3

eslint changes

7a92db1

eslint changes

c416e67

changes

75fc60d

changes

1397606

mkyloa closed this Jun 6, 2023

mkyloa reopened this Jun 6, 2023

mkyloa requested a review from ihor-jpeg June 6, 2023 10:51

mkyloa closed this Jun 6, 2023

mkyloa reopened this Jun 6, 2023

mkyloa suggested changes Jun 6, 2023

View reviewed changes

mkyloa self-requested a review June 6, 2023 11:00

DorotaLeniecDev suggested changes Jun 6, 2023

View reviewed changes

Apply requested changes

3fd8c2d

arturgorniak added 2 commits June 6, 2023 17:59

problem fix

9963a71

some more fix

aab4e1c

arturgorniak requested a review from DorotaLeniecDev June 6, 2023 16:07

darokrk suggested changes Jun 9, 2023

View reviewed changes

final changes

6d58a9c

arturgorniak requested a review from darokrk June 9, 2023 14:40

DorotaLeniecDev suggested changes Jun 12, 2023

View reviewed changes

final changes

162df8f

arturgorniak requested a review from DorotaLeniecDev June 23, 2023 15:04

arturgorniak mentioned this pull request Jun 30, 2023

moyo header task solution mate-academy/layout_moyo-header#3407

Open

		<meta name="viewport"
		content="width=device-width, user-scalable=no, initial-scale=1.0, maximum-scale=1.0, minimum-scale=1.0"

		<form action="https://mate-academy-form-lesson.herokuapp.com/create-application"
		method="post" name="personal-information">

		content="width=device-width, user-scalable=no, initial-scale=1.0,
		maximum-scale=1.0, minimum-scale=1.0"

Conversation

arturgorniak commented Jun 5, 2023

Uh oh!

mkyloa left a comment

Choose a reason for hiding this comment

Uh oh!

mkyloa left a comment

Choose a reason for hiding this comment

Uh oh!

DorotaLeniecDev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arturgorniak commented Jun 6, 2023

Uh oh!

darokrk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arturgorniak commented Jun 9, 2023

Uh oh!

DorotaLeniecDev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arturgorniak commented Jun 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants