Open
Conversation
lerastarynets
suggested changes
Jul 26, 2023
lerastarynets
left a comment
lerastarynets
left a comment
There was a problem hiding this comment.
Nice start! Let's fix and improve your work a little bit)
Anastasiia-Svintsova
suggested changes
Jul 26, 2023
Author
|
I've resolved all the requested changes. |
maxim2310
approved these changes
Jul 27, 2023
maxim2310
left a comment
maxim2310
left a comment
There was a problem hiding this comment.
fixed but in next task use kebab-case for class naming instead camelCase
Comment on lines
+32
to
+39
| <input | ||
| name="Name" | ||
| type="text" | ||
| autocomplete="off" | ||
| required | ||
| minlength="5" | ||
| maxlength="25" | ||
| > |
There was a problem hiding this comment.
Suggested change
| <input | |
| name="Name" | |
| type="text" | |
| autocomplete="off" | |
| required | |
| minlength="5" | |
| maxlength="25" | |
| > | |
| <input | |
| name="Name" | |
| type="text" | |
| autocomplete="off" | |
| required | |
| minlength="5" | |
| maxlength="25" | |
| > |
Comment on lines
+119
to
+120
| for="No" | ||
| class="form_field firstInput eighthInput-2" |
There was a problem hiding this comment.
Suggested change
| for="No" | |
| class="form_field firstInput eighthInput-2" | |
| for="No" | |
| class="form_field firstInput eighthInput-2" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://TheOldDream.github.io/layout_html-form/
https://TheOldDream.github.io/layout_html-form/report/html_report/