Conversation
Zibi95
left a comment
Zibi95
left a comment
There was a problem hiding this comment.
Hey. Can you tell which part have you ended. I can see that desktop layout is completely off. Form after submission shouldn't reload (check CHECKLIST.md). Missing links under contact form with special protocol (mailto:: for example) also link to google maps. Details should be in CHECKLIST.md
natalia-klonowska
left a comment
natalia-klonowska
left a comment
There was a problem hiding this comment.
- Form shouldn't be submitted if some of the fields are not filled
- disable page scrolling under the menu
There was a problem hiding this comment.
Use only full version of this image (mybike-header-full.jpg) and adjust its position to match figma design. This way the image will scale properly when browser window is resized because right now it looks like this:
index.html
Outdated
| <div class="pictures__one"> | ||
| <img src="/src/images/photos/pic-1.jpg" class="pictures__two" |
There was a problem hiding this comment.
elements with pictures__one and pictures__two classes should be placed inside element with pictures class
index.html
Outdated
| <p class="article__paragraph--bold">Sporty 4</p> | ||
| <p class="article__paragraph--normal">The iconic frame brought to a new performance height as a sporty, active ride.</p> | ||
| <p class="article__paragraph--price">$ 2 590</p> |
There was a problem hiding this comment.
Typical BEM Mistakes: Using a Modifier Without the Belonging Class
index.html
Outdated
| <textarea id="message" class="form__textarea" | ||
| placeholder="Message"></textarea> | ||
| </div> | ||
| <button class="button--primary">Send</button> |
There was a problem hiding this comment.
Typical BEM Mistakes: Using a Modifier Without the Belonging Class
index.html
Outdated
|
|
||
| <address class="address"> | ||
| <h4 class="address__label">Phone</h4> | ||
| <p class="address__label--content">+1 234 5555-55-55</p> |
There was a problem hiding this comment.
Typical BEM Mistakes: Using a Modifier Without the Belonging Class
Zibi95
left a comment
Zibi95
left a comment
There was a problem hiding this comment.
Hey. Nice progress. Found some issues that we should fix.
- any logo should be a link to the home page. In header, its fragment link to the header.
- Pictures in Gallery should increase on hover. There is inconsistency, some are increasing and others are changing border color.
- email in link in form should use link with
ematilto::protocol
- address label above those link don't need any hover effects
-
in many places spacing is off. You are using margin bottom and margin top, which complicates things. Just try to use one of those.
-
Almost all hover effects cause Layout shift on the page.
- Scroll when nav menu is open should be disabled
4 participants
DEMO LINK