Initial landing page layout with categories – needs further design improvements and content fixes#2720
Initial landing page layout with categories – needs further design improvements and content fixes#2720Tomek93x wants to merge 39 commits intomate-academy:masterfrom
Conversation
…provements and content fixes
- Add favicon link to index.html head section - Use logo.png as favicon source - Fix stylelint CSS formatting errors - Ensure smooth animations and transitions
natalia-klonowska
left a comment
natalia-klonowska
left a comment
There was a problem hiding this comment.
deploy your project (npm run deploy) and add demo link to pr description
|
https://tomek93x.github.io/layout_miami/ |
natalia-klonowska
left a comment
natalia-klonowska
left a comment
There was a problem hiding this comment.
- why your project doesn’t match design in Figma? https://www.figma.com/design/DtkQmQ797hk0nI4KfMi2Uq/BOSE-New-Version?node-id=6703-88&p=f&t=q4O04jola0WE8c73-0
- many elements are missing class attributes that you later reference for styling (e.g. button without the btn class)
- each bem block from main.scss should have separate file
src/images/E-mail.png
Outdated
There was a problem hiding this comment.
delete all images of inputs and buttons
|
I create separate files blocks from main.css, add missing elements, design now looks like from Figma, now it should be ok :) |
natalia-klonowska
left a comment
natalia-klonowska
left a comment
There was a problem hiding this comment.
layout is not responsive it's fixed with breakpoints which results in too large margins between them:
Here you can find a comparison between fixed and responsive layouts and here you can see example of responsive layout with breakpoints
- disable page scrolling under the menu
-
When you click on phone number in contacts section, make sure that there is no 404 error, make it a real link to start a call on device
-
apply validation of the form fields (required, email / tel etc.), then it is clear in what format to enter the data
-
Form shouldn't be submitted if some of the fields are not filled
natalia-klonowska
left a comment
natalia-klonowska
left a comment
There was a problem hiding this comment.
-
CHECKLIST: Page shouldn't be reloaded on form submit
-
When navigating page content overlaps with closing menu
on the front page it looks correct:
here you can see the overlapping issue:
natalia-klonowska
left a comment
natalia-klonowska
left a comment
There was a problem hiding this comment.
final adjustments ;)
- use higher quality images as they don't display well just before switching to tablet version and also adjust spacing of texts under images:
- spacing is too large in mobile version and tablet version should have a different layout:
poprawiłem layout, zmiejszyłem gapa poniedzy sekcjami, oraz poprawiłem jakośc zdjęć |
2 participants
No description provided.