Skip to content

BOSE page#2721

Open
wojthecode wants to merge 56 commits intomate-academy:developfrom
wojthecode:develop
Open

BOSE page#2721
wojthecode wants to merge 56 commits intomate-academy:developfrom
wojthecode:develop

Conversation

@wojthecode
Copy link

@wojthecode wojthecode commented Dec 1, 2025

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deploy your project using npm run deploy command and add demo link to pr description

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHECKLIST:

  • Change text color on hover for phone, email and address
  • When clicking on any location / address - prevent errors and make it to open location in Google Maps
  • Pictures in Gallery should increase on hover
  • Form shouldn't be submitted if some of the fields are not filled
  • Page shouldn't be reloaded on form submit
  • disable page scrolling under the menu

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • contact section next to form should start at the same height and submitting form shouldn’t reload the page instead you can add success message and clear inputs
image
  • phone icon is too large on mobile version and icon in the title should be positioned higher with more spacing from title
image

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using action="#" and fetch("#") may work on localhost but in deployed version it causes page reload

<section class="main__section main__section--contact" id="contact">
<h2 class="title title__main title__main--contact">Contact us</h2>

<form action="#" class="contact">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<form action="#" class="contact">
<form class="contact">

Comment on lines +7 to +12
const formData = new FormData(contactForm);

fetch("#", { // <- server address
method: "POST",
body: formData
})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const formData = new FormData(contactForm);
fetch("#", { // <- server address
method: "POST",
body: formData
})

Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.