Conversation
natalia-klonowska
left a comment
natalia-klonowska
left a comment
There was a problem hiding this comment.
- center or scale images because current layout leaves too much empty space and look unbalanced
- same problem with images and you're missing margin between first and second article
There was a problem hiding this comment.
mobile version should use full image to ensure proper scaling on screen resize
There was a problem hiding this comment.
mobile version should use full image to ensure proper scaling on screen resize
- delete this version of image and use only full size version
There was a problem hiding this comment.
mobile version should use full image to ensure proper scaling on screen resize
- delete this version of image and use only full size version
index.html
Outdated
| <h3 class="details__tittle">The details</h3> | ||
|
|
||
| <article class="details__detail"> | ||
| <div class="details__detail__photos"> |
There was a problem hiding this comment.
Typical BEM Mistakes: in BEM you never use __ multiple times
natalia-klonowska
left a comment
natalia-klonowska
left a comment
There was a problem hiding this comment.
delete all src copies and zip files. deploy your project once again and make sure that your demo link works
index.html
Outdated
| <link | ||
| rel="stylesheet" | ||
| href="src/styles/main.scss" | ||
| href="src/styles/main.css" |
There was a problem hiding this comment.
you don't have main.css file. use main.scss
index.html
Outdated
| <header class="header" id="home"> | ||
| <nav class="header__nav"> | ||
|
|
||
| <h1 class="header__nav--logo">MyBiKE</h1> |
There was a problem hiding this comment.
-- is used for modifiers not elements and modifiers should always be used together with their belonging class
you can apply one of the following conventions:
- replace all
--with-
| <h1 class="header__nav--logo">MyBiKE</h1> | |
| <h1 class="header__nav-logo">MyBiKE</h1> |
- keep only the part after
--
| <h1 class="header__nav--logo">MyBiKE</h1> | |
| <h1 class="header__logo">MyBiKE</h1> |
- create separate
navblock
| <h1 class="header__nav--logo">MyBiKE</h1> | |
| <header class="header" id="home"> | |
| <nav class="header__nav nav"> | |
| <h1 class="nav__logo">MyBiKE</h1> |
index.html
Outdated
| </section> | ||
|
|
||
| <section class="compare"> | ||
| <h3 class="h3-title">Compare bikes</h3> |
There was a problem hiding this comment.
remember that you're using BEM methodology so for consistency you should treat h3-title and h4-title as blocks and create separate files for their styles.
or you can create title block with modifiers title--h3 and title--h4
danon321
left a comment
danon321
left a comment
There was a problem hiding this comment.
Tutaj na mobile cos sie poprzesuwało. I tez nie powinno byc tak ze tekst wylatuje ci za linie grafiki. Wyglada to nieestetycznie.
Contact us tak samo leci do lewej
Desktop
Na szerszych monitorach jak desktop czy laptop twoj kontent jest bardzi scisniety do srodka. Przypatrz sie na figmie ze jest on rozciągniety do 1020px
Left: hover and active.
3 participants
First block