Open
Conversation
natalia-klonowska
suggested changes
Dec 29, 2025
natalia-klonowska
left a comment
natalia-klonowska
left a comment
There was a problem hiding this comment.
- ensure that no elements are on the same layer as menu as they remain visible during section navigation
- phone and burger icons should be bigger on tablet and desktop versions (24px instead of 18px)
index.html
Outdated
|
|
||
| <h2 class="about__title-2">The Met Fifth Avenue</h2> | ||
|
|
||
| <div class="about__item about__open-time"> |
There was a problem hiding this comment.
you only use about__open-time together with about__item so it would be better to make about__open-time a modifier of about__item e.g. about__item--open-time
natalia-klonowska
suggested changes
Dec 30, 2025
Comment on lines
+35
to
+43
| <a href="tel:+1 212-923-3700" class="phone"> | ||
| <div class="phone__label"> | ||
| <p>The Met Fifth Avenue</p> | ||
| <p>+1 212-535-7710</p> | ||
| <p>The Met Cloisters</p> | ||
| <p>+1 212-923-3700</p> | ||
| </div> | ||
| <div class="header__phone"></div> | ||
| </a> |
There was a problem hiding this comment.
BEM: header__phone is nested inside phone block so it should use phone__ prefix instead of header__
index.html
Outdated
| <img | ||
| src="src/images/icons/close.svg" | ||
| alt="close" | ||
| class="menu__close"> |
There was a problem hiding this comment.
BEM: menu__close is nested inside navigation block so it should use navigation__ prefix instead of menu__
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[DEMO LINK] (https://Qbusik.github.io/layout_miami/)